Upgrade agents dev container Feature to v3#3
Merged
Merged
Conversation
Bump ghcr.io/rocicorp/devcontainer-features/agents from :1 to :3 in both templates (node, sibling-services). v3 is a breaking release that drops the bundled GitHub CLI (gh) and 1Password CLI (op), so the container no longer injects a GitHub token at shell start. - Drop the now-inaccurate "+ gh" from the feature comment in both configs. - No in-container gh/op usage exists (postCreateCommand is just `pnpm install`; the only GITHUB_TOKEN is in CI's release.yml), so no token wiring needed removal and github-cli was not re-added. - Add .github/dependabot.yml with a weekly devcontainers update grouped across the two template folders (/src/node, /src/sibling-services).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgrades both dev container templates to v3 of the
rocicorp/devcontainer-features/agentsFeature.agentsv3.0.0 is a breaking release: it drops the bundled GitHub CLI (gh) and 1Password CLI (op), so the container no longer injects a GitHub token (or 1Password credentials) at shell start. Migration note: https://github.com/rocicorp/devcontainer-features#agentsChanges
Pin bump (
:1→:3) — applied to everydevcontainer.jsonin the repo:src/node/.devcontainer/devcontainer.jsonsrc/sibling-services/.devcontainer/devcontainer.jsonBoth were on
:1(not:2). Thepnpm:1pins are left alone (still on their current major). NocodexVersionoption was present, so nothing to preserve there.Dead-wiring removal — dropped the now-inaccurate
+ ghfrom the feature-description comment in both files. That comment was the onlygh/opreference tied to the bundled tooling.Dependabot — added
.github/dependabot.ymlwith adevcontainersecosystem entry (weekly, all feature updates grouped). Because the configs live undersrc/<template>/.devcontainer/rather than a root.devcontainer/, it usesdirectories: ["/src/node", "/src/sibling-services"]so Dependabot finds both.No
devcontainer-lock.jsonexists beside either config, so there was no lockfile to regenerate.Risk: risk-free ✅
Nothing inside the container uses
ghorop:postCreateCommandin both templates is justpnpm install.remoteEnv/${localEnv:...}token passthrough, noGITHUB_TOKEN, noOP_SERVICE_ACCOUNTin any devcontainer config.GITHUB_TOKENin the repo is in.github/workflows/release.yml— the standard GitHub Actions token used to publish templates to ghcr.io. That runs in CI, not inside the dev container, so it is unrelated to the dropped bundledghand was left untouched.Because no in-container script or lifecycle command depended on the bundled
gh/op, the officialgithub-cliFeature was not re-added. Dropping the token wiring is therefore a no-op for behavior.Verification
:1/:2; no orphanedgh/op/1Password/GITHUB_TOKENreferences remain in the templates.devcontainer.jsonfiles still parse (JSONC) anddependabot.ymlis valid.Generated by Claude Code