You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the follow-up @leoarnold - consolidating logger into the gemspec (and dropping the Gemfile duplicate) makes sense.
One thing though: unlike base64/bigdecimal/mutex_m (which we only need so older Rails can load in our test matrix), logger is required by lograge's own runtime code (require 'logger' in lib/lograge.rb). Since we support activesupport >= 4, and activesupport didn't declare logger as a runtime dependency until Rails 7.1, an app on Rails ≤ 7.0 with Ruby 3.5+ (where logger is no longer a default gem) could fail to load lograge but, a development_dependency wouldn't help those users.
What do you think about making it s.add_dependency 'logger' (runtime) instead? That protects consumers, and it can stay out of the dev block / Gemfile entirely. Happy to merge once that's adjusted.
@leoarnold lemme figure out how we might relax/ignore that rubocop rule breaking your build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #399.