feat: add --escalation-policy-id flag to services update#45
Conversation
Greptile SummaryThis PR adds
Confidence Score: 5/5Safe to merge — the change is well-scoped, follows existing patterns throughout the codebase, and is covered by both API-level and command-level tests. All four service API methods are updated consistently, the attach/detach logic is straightforward and tested with table-driven cases that assert on both the returned struct and the serialized request body, and no existing behavior is altered. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "✨ feat: [PRF-2820] add --escalation-poli..." | Re-trigger Greptile |
Allows attaching/detaching escalation policies on services via CLI, closing a gap that forced CI/CD pipelines to fall back to raw API calls. Empty string sends JSON null to detach; non-empty attaches. Also displays escalation policy ID in `services get` detail view. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
5f7b77d to
3d8587b
Compare
Summary
--escalation-policy-idflag torootly services updateso CI/CD pipelines can attach or detach escalation policies on services without raw API calls (PRF-2820)--escalation-policy-id="") sends JSONnullto detach; non-empty string attachesrootly services getdetail viewescalation_policy_idfrom API responses across all service methods (List, Get, Create, Update)Test plan
go test ./internal/...— all 483 tests passgo vet ./...— no issuesrootly services update <svc> --escalation-policy-id=<ep-id>thenrootly services get <svc>rootly services update <svc> --escalation-policy-id=""to verify detach