Support CRC32 in JRuby#128
Open
olleolleolle wants to merge 2 commits into
Open
Conversation
olleolleolle
force-pushed
the
add-a-java-crc32
branch
2 times, most recently
from
4a5d11d to
c06110b
Compare
Use java.util.zip.CRC32
Tests cover: byte order, digest/block length, empty input, null and high bytes (unsigned masking), full lookup table, incremental vs one-shot, clone independence, reset, non-destructive digest, digest! state reset, and initialize_copy frozen-destination enforcement.
olleolleolle
force-pushed
the
add-a-java-crc32
branch
from
c06110b to
03d3764
Compare
Contributor
Author
|
@headius I updated this PR to also avoid deprecation warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports CRC32 in the JRuby extension.
Following #127
Thanks, @headius. Thanks, @kares.