Skip to content

grand-flip-out: update to 2050a9f#14210

Open
Tunatroll wants to merge 1 commit into
runelite:masterfrom
Tunatroll:advisor-hold-for-sell
Open

grand-flip-out: update to 2050a9f#14210
Tunatroll wants to merge 1 commit into
runelite:masterfrom
Tunatroll:advisor-hold-for-sell

Conversation

@Tunatroll

Copy link
Copy Markdown
Contributor

Updates grand-flip-out from 3194620 to 2050a9f — keeps the Advisor's flip card visible until you place the matching sell offer, fixing a UX gap reported by a user. Information-only (no automation, no trade execution) and Java 11 / ./gradlew clean build-clean (96/96 tests, 0 failures).

Highlights

  • Advisor card now HOLDS after you collect a completed buy — it no longer jumps to the next suggestion before you've placed the matching sell offer, so you don't have to memorize the sell price/quantity. A "Next flip" button lets you skip ahead manually. New advisorHoldForSell config toggle (on by default) fully restores the old behavior when turned off.
  • Fixed a config-item position collision that the hold-for-sell item introduced with the existing GE-offer-auto-fill / mix-slot settings.

Compliance

  • No terminally-deprecated or banned APIs; no reflection, subprocess, or synthetic input.
  • Pure client-side UI/state change — no new network calls and no new data ever leaves the client, so no new manifest warning= is needed.
  • UI mutation runs on the Swing EDT via SwingUtilities.invokeLater; game-state reads stay on the existing client-thread path.

@runelite-github-app

Copy link
Copy Markdown

@runelite-github-app

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant