Use Xoshiro256PlusPlus in examples/rayon-monte-carlo.rs#1805
Open
dhardy wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SmallRngandStdRngfrom this benchmark (both are thin wrappers around another benchmarked PRNG)rayon-monte-carloexample to useXoshiro256PlusPlusinstead ofChaCha8RngMotivation
Upon consideration of #1781, it occurs to me that there is very little reason to use a thread-local
SmallRnginstead of a new local one. (In fact, a thread-local one would likely perform worse if we were to use the same per-usage locking as we do inThreadRng.)Details
The rayon example now uses multiple seeds instead of a single seed with multiple streams/jumps. I believe this is acceptable. We could instead use
jumporjump_n, though (a) we don't have those facilities in therand::rngscode and (b) I see no reason why this would be preferable. See also the book: parallel RNGs. CC @vigna.