Do not repeat helobytes in MiIOProtocol.discover#2004
Open
kbpk wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2004 +/- ##
=======================================
Coverage 82.26% 82.27%
=======================================
Files 197 197
Lines 19145 19144 -1
Branches 1052 1051 -1
=======================================
Hits 15750 15750
Misses 3218 3218
+ Partials 177 176 -1 ☔ View full report in Codecov by Harness. |
syssi
force-pushed
the
fix/miio_protocol_handshake
branch
from
ae31a78 to
6d9eb7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrying handshake is implemented in
MiIOProtocol.send_handshake. Spamminghelobyteswithout any delay or receiving data causes errors.