Use more strict rector rules#289
Open
CarlSchwan wants to merge 4 commits into
Open
Conversation
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
|
The CI is completely red |
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/rector-strict
branch
from
July 14, 2026 15:39
35b684e to
faa702e
Compare
Contributor
Author
fixed |
Contributor
|
cs-fixer still wants to line-up a few comments. |
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/rector-strict
branch
from
July 15, 2026 08:49
71cdc85 to
e16bab0
Compare
Contributor
|
https://github.com/sabre-io/http/actions/runs/29402155718/job/87309000578?pr=289 And needs a rebase anyway, the other "hmac" PR was just merged. |
phil-davis
reviewed
Jul 15, 2026
Contributor
There was a problem hiding this comment.
@CarlSchwan please write some words about why you have proposed these Rector rule sets.
(when we decide on new/changed rule sets, we will want to apply them to all the sabre-io repos)
phil-davis
reviewed
Jul 15, 2026
Comment on lines
-32
to
+33
| self::assertFalse($result, 'No AWS Authorization header was supplied, so we should have gotten false'); | ||
| self::assertEquals(AWS::ERR_NOAWSHEADER, $this->auth->errorCode); | ||
| $this->assertFalse($result, 'No AWS Authorization header was supplied, so we should have gotten false'); | ||
| $this->assertSame(AWS::ERR_NOAWSHEADER, $this->auth->errorCode); |
Contributor
There was a problem hiding this comment.
These are all a bit surprising. I thought that the PHPunit Assert library were all static methods, and previous iterations of code-style and analysis recommended using the :: static calling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1rst commit is mostly modifying rector and second is running rector
I reviewed manually all the changes in lib but not in tests