Skip to content

Feature/darkmode#13

Open
r-4bb1t wants to merge 4 commits into
sakofchit:mainfrom
r-4bb1t:feature/darkmode
Open

Feature/darkmode#13
r-4bb1t wants to merge 4 commits into
sakofchit:mainfrom
r-4bb1t:feature/darkmode

Conversation

@r-4bb1t

@r-4bb1t r-4bb1t commented Sep 11, 2022

Copy link
Copy Markdown

I modified it so that it can be used if you give the html tag a darkmode classname. There may still be some shortcomings.

@sakofchit

sakofchit commented Sep 15, 2022

Copy link
Copy Markdown
Owner

this is a good start! but it looks like it breaks a few things:

  1. default buttons don't have the black border

Screen Shot 2022-09-14 at 11 43 55 PM

  1. selected dropdown menu isn't highlighted

Screen Shot 2022-09-14 at 11 44 24 PM

  1. Darkmode scrollbar arrow svgs don't seem to display

Screen Shot 2022-09-14 at 11 46 50 PM

  1. box shadows should probably have a white offset instead of black

Screen Shot 2022-09-14 at 11 48 01 PM

@r-4bb1t

r-4bb1t commented Sep 15, 2022

Copy link
Copy Markdown
Author

I revised the contents you wrote, so I'd appreciate it if you could check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants