Add ffiam to opencsp#330
Merged
Merged
Conversation
Collaborator
Author
|
I think the last 2 bullet point requirements can wait, because we wanted to get this in an independent projects folder and then work on integrating it further into the OpenCSP ecosystem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This Pull Request is to get the FFIAM (Full Field Irradiance Analysis Model) repositories from Sandia's internal GitLab to the Sandialabs open sourced GitHub repository. There are 2 folders added. FFIAM and FFIAM-UE, where UE is Unreal Engine.
Summary of changes
New addition of an independent code base, with future plans to further integrate into OpenCSP.
Implementation notes
Tested building locally for the majority of the project, was able to reproduce.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordinglyAdditional information
Please provide any additional information here.