Stop logging hub auth token#201
Open
matt-richardson wants to merge 1 commit into
Open
Conversation
The options flow logged the bearer token directly (logger.error(token)) and dumped the full user_input dict — which contains CONF_TOKEN — at ERROR level in two places. The token is long-lived and grants full control of the hub, and the README instructs users to paste HA logs into public GitHub issues, so this risked leaking hub control to anyone reading a bug report. Remove the token/user_input logging and downgrade the surrounding diagnostic chatter from error to debug. No token is written to logs at any level now. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick "hey claude, is this plugin safe to use" scan highlighted that the options flow
dict(which containsCONF_TOKEN) at ERROR level in two places.The token is long-lived and grants full control of the hub, so should never be logged.
The README also instructs users to paste HA logs into public GitHub issues, risking leakage
Results
Describe your changes
This PR removes the token (line 212) and user_input (218) logging and downgrades the surrounding diagnostic chatter from error to debug.
Checklist before submitting a pull request
Updated base lib and added the required version in theN/A (i think?)requirements.txtandmanifest.jsonChecklist for reviewer