test(storcli2): on-hardware e2e harness + sibling layout

[g-carre]

Summary

Adds a manual on-hardware e2e harness for the storcli2/perccli2 composition adapter (ARTESCA-17652) and reorganizes the integration harnesses so each adapter is clearly identifiable in its own sibling directory. Stacked on #73.

tests/integration/
  mdadm/      # moved: existing software-RAID (RHEL8/mdadm) harness
  storcli2/   # new: MegaRAID/PERC harness
  README.md   # documents both + cross-compile line

storcli2 harness — argument-driven

• Default (no args): read-only inventory — lists controllers, physical drives and logical volumes as markdown tables. Safe to run anywhere.
• Destructive commands require -confirm: create, add (expand), delete, and a full scenario (create → assert drive-removal unsupported → optional expand → delete).
• storcli2 can't remove drives, so the scenario exercises removal as a negative case (asserts ErrFunctionNotSupportedByImplementation) rather than mutating the array.
• The same composition serves both binaries via -binary (point it at perccli2 for PERC).

Notes / deviations from the ticket

• Layout differs from the ticket's suggested tests/e2e-storcli2/ — per request, both adapters now sit side by side under tests/integration/{mdadm,storcli2}/ for clarity.
• Scope is a superset of the ticket's read-only inventory: it keeps inventory as the default but adds opt-in destructive tasks/scenario behind -confirm, as discussed.
• Imports only pkg/implementation/... and pkg/core (not pkg/infrastructure); cross-compile line documented in the README and main.go.

Testing

go build ./..., go vet ./tests/integration/..., gofmt, and the full unit suite pass. Verified locally that the default inventory fails gracefully (no panic) when the binary is absent, and that destructive commands refuse to run without -confirm.

Note: Targets feature/storcli2-raidcontroller-composition (#73), not main, per the stack.

Issue: ARTESCA-17652

🤖 Generated with Claude Code

[claude]

LGTM — clean integration harness. Error handling follows existing patterns (pkg/errors wrapping, errors.Is chain traversal through core wrappers). Deferred cleanup in Scenario is correctly scoped after Create. Safety guards (-confirm) and build-only CI job are appropriate.

Review by Claude Code

[claude]

• .github/workflows/pre-merge.yaml:68 — build-e2e job uses actions/checkout v6, rest of workflow uses v7.0.0. Should be aligned.
  
  Everything else looks clean: error wrapping is consistent, the hexagonal boundaries are respected (only pkg/implementation and pkg/core are imported), the Scenario deferred cleanup and named-return interaction is correct, parseDrives handles empty input, and humanBytes is sound for all uint64 values.
  
  Review by Claude Code

[claude]

LGTM

Review by Claude Code

[claude]

• .github/workflows/pre-merge.yaml:67 — actions/checkout pinned to v6, should be v7.0.0 to match the other jobs
  
  Everything else looks solid: error handling follows project conventions (pkg/errors wrapping, sentinel reuse), adapter wiring is correct, the confirmation guard is effective, and the Scenario cleanup-via-defer with named returns is sound.
  
  Review by Claude Code

[ezekiel-alexrod]

Check this one before merging: #74 (comment)

[claude]

-drives is not validated for create, add, or scenario, unlike -vd which is checked for add/delete. If -drives is omitted, parseDrives returns an empty slice. For scenario this leads to an unguarded drives[0] panic in hardware_raid_controller.go:162; for create/add the adapter gets an empty list and produces a confusing error.

Suggested change

	return err
	case "create":
	level, err := parseRAIDLevel(opts.raidLevel)
	if err != nil {
	return err
	}
	if opts.drives == "" {
	return errors.New("create requires -drives")
	}

Same pattern needed for add (line 125) and scenario (line 133).

— Claude Code

[claude]

• tests/integration/storcli2/main.go:115 — missing -drives validation in dispatch for create/add/scenario commands; omitting the flag causes a confusing adapter error or a panic on drives[0] in the scenario path (hardware_raid_controller.go:162). Add guards matching the existing -vd checks.
  
  Review by Claude Code