APP-21128 send telemetry as JSON#2
Merged
Merged
Conversation
aviaviavi
approved these changes
May 28, 2026
aviaviavi
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the current diff, PR metadata, CI status, and existing review discussion. The change correctly moves telemetry properties from query parameters into a JSON request body, preserves the configured endpoint URL, sets Content-Type: application/json, and keeps tests aligned with the new behavior. CI is green and local configure/build/test passed for me as well.
AI-generated review disclaimer: this review was generated by Codex using the GPT-5 Codex desktop harness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Type: application/jsonon SDK requests while preserving the configured endpoint URL exactly.Validation
PATH="/usr/local/opt/llvm@20/bin:$PATH" /usr/local/bin/treefmt CMakeLists.txt include/scarf/event_logger.hpp src/event_logger.cpp src/curl_transport.cpp tests/event_logger_test.cpp examples/basic.cpp README.md .github/workflows/ci.yml treefmt.toml .clang-formatCXX=/usr/local/opt/gcc/bin/g++-15 cmake -S . -B build-app21128 -DSCARF_CPP_BUILD_TESTS=ONcmake --build build-app21128 --parallelctest --test-dir build-app21128 --output-on-failurecmake --install build-app21128 --prefix /tmp/scarf-cpp-install-app21128find_package(scarf-cpp CONFIG REQUIRED)consumer configure/build withCXX=/usr/local/opt/gcc/bin/g++-15Linear: APP-21128