Fix correctness and crash issues - #228
Open
Thorium wants to merge 1 commit into
Open
Conversation
- ExpressionStarter<T>.Not() on an unstarted predicate now negates the DefaultExpression instead of always starting with 'x => false', so PredicateBuilder.New<T>(false).Not() correctly matches everything. - A custom query optimizer passed to AsExpandable() is no longer silently dropped: it now survives query composition (CreateQuery/Include re-wrap with the same optimizer), is applied on the non-generic CreateQuery and EF Core 2 async streaming paths, and an explicitly passed optimizer rewraps an already-wrapped query instead of being ignored. - Guard the reflection lookup of EntityQueryProvider._queryCompiler so a future EF Core rename degrades gracefully instead of throwing NRE. - EvaluateTarget no longer throws for user-defined Compile() methods declared on non-generic types (GetGenericTypeDefinition guard). - EF Core 2 ExecuteAsync now throws a descriptive InvalidOperationException when the inner provider is not async, instead of NullReferenceException. Adds regression tests covering each fix; all verified to fail against the previous implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpressionStarter.Not() on an unstarted predicate now negates the DefaultExpression instead of always starting with 'x => false', so PredicateBuilder.New(false).Not() correctly matches everything.
A custom query optimizer passed to AsExpandable() is no longer silently dropped: it now survives query composition (CreateQuery/Include re-wrap with the same optimizer), is applied on the non-generic CreateQuery and EF Core 2 async streaming paths, and an explicitly passed optimizer rewraps an already-wrapped query instead of being ignored.
Guard the reflection lookup of EntityQueryProvider._queryCompiler so a future EF Core rename degrades gracefully instead of throwing NRE.
EvaluateTarget no longer throws for user-defined Compile() methods declared on non-generic types (GetGenericTypeDefinition guard).
EF Core 2 ExecuteAsync now throws a descriptive InvalidOperationException when the inner provider is not async, instead of NullReferenceException.
Adds regression tests covering each fix; all verified to fail against the previous implementation.