Skip to content

Refine affected-test and PR-gate workflow#400

Merged
screenleon merged 3 commits into
mainfrom
agent/refactor-reuse-before-pr-gate
Jul 14, 2026
Merged

Refine affected-test and PR-gate workflow#400
screenleon merged 3 commits into
mainfrom
agent/refactor-reuse-before-pr-gate

Conversation

@screenleon

Copy link
Copy Markdown
Owner

Summary

  • 修正 run-tests.sh 的 frontmatter suite 對應,避免 agents、commands、skills 的變更選到未註冊 suite 而漏測
  • 將維護流程調整為:affected tests → refactor/reuse audit → PR gate → 視架構調整決定是否再次 audit → full suite
  • PR gate 優先使用與實作不同的 model family,不再以 Codex/Claude host 名稱硬編碼判斷
  • 新增 CC-487,獨立追蹤 GitHub Actions test-guards 非確定性卡住、背景程序清理與診斷不足

Why

原本 frontmatter 路徑映射到不存在的 lint-frontmatter suite,造成相關變更可能沒有執行預期測試。同時,完整測試過早執行及依 host 名稱選 gate model,會增加迭代成本,也無法正確涵蓋 OpenCode 可使用多種 model 的情況。

Impact

  • 實作迭代階段只跑受影響測試,PR gate 通過後才執行一次 full suite
  • 主要實作完成後先確認重構與重用,降低後續維護成本
  • PR gate 修正若涉及較大架構調整,必須再次執行 refactor/reuse audit;小幅修正則可略過
  • gate reviewer 依實際 model family 選擇,提高跨模型找出問題的機會

Validation

  • bash scripts/test-run-tests.sh — 15/15 passed
  • bash scripts/test-commands.sh — 291/291 passed
  • bash scripts/run-tests.sh --base origin/main — 6/6 selected suites passed
  • Claude Sonnet 5 PR gate — GO
  • bash scripts/run-all-tests.sh — 77 passed, 0 failed, 0 skipped
  • bash scripts/run-tests.sh --verify-full .pm-dispatch/test-results/latest-full.json
  • ./cli/pmctl backlog lint
  • git diff --check

@screenleon screenleon marked this pull request as ready for review July 14, 2026 02:52
@screenleon screenleon merged commit 565b7c2 into main Jul 14, 2026
49 checks passed
@screenleon screenleon deleted the agent/refactor-reuse-before-pr-gate branch July 14, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant