Harden canonical memory host contracts#401
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dispatch.memory_diroverride with project-key-scoped memory configuration, migration, lint, and fail-closed resolutionWhy
The canonical memory data itself was healthy, but Codex live wiring lacked the complete Stop writer contract and natural-language update routing. The existing global explicit memory path also allowed unrelated repositories to resolve to the same canonical store, creating a cross-project write risk.
The implementation now keeps project identity separate from initiating host provenance: Claude, Codex, OpenCode, and future hosts share the same repository-owned canonical store while every write requires an explicit source host.
Validation
bash scripts/run-tests.sh --base main: PASStest-pmctl-memory: 74/74test-pmctl-pm: 30/30pmctl backlog lint: PASSgit diff --check: PASS~/.claude/statusline-chain.confremained byte-identical across the required reinstallAccepted full-suite exception
The authoritative full run completed 76 of 77 suites successfully. The only failure was
test-guards, which reached the 900-second suite timeout while blocked in the known CC-487 contention/hang path:memory-usage/contention-matrix-flock-and-mkdir-fallbackThis is an existing tracked nondeterministic runner issue, not a canonical-memory product regression. Running the same suite independently immediately afterward completed successfully with 298/298 passing. Per the accepted CC-487 boundary, this known timeout does not block opening this PR; the full-suite artifact is intentionally not described as fully green.
Follow-up
CC-491 tracks a separate mechanical evidence contract so PR-gate can pass commands, selected suites, per-suite outcomes, and tree fingerprints to QA reviewers without redundant test execution.