Harden guard concurrency diagnostics#402
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-guards.shwaittest-guardsjob at 15 minutesRoot cause
The direct GitHub Actions guard job exposed only a section heading while several concurrency cases used background writers, FIFO coordination, and bare
wait. If a writer failed to converge, the job had neither a case-level deadline nor enough process context to identify and reap the child, allowing one case to consume nearly the entire runner window.Impact
Guard concurrency failures now terminate within a bounded deadline and report the active case, backend, round, writer label, PID, process state, lock state, and completion counts. Normal correctness assertions, writer counts, flock coverage, and mkdir-fallback coverage remain unchanged.
Validation
test-guards300/300)gate-20260714-075600-a3affd: Final GOgate-20260714-080619-5069e6: Final GO79a61fbb6b1566c2e80dca00d307346bc727e0ce3c510d72cbee447fa71b7f78One intermediate full run observed an unrelated load-sensitive
test-run-all-testsfailure; that suite passed standalone 34/34, and the unchanged tree then completed a clean authoritative 77/77 full run.