Fix UI and navigation for download data banner #653
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's looking and working great here, @prince-0408! Thanks so much for the great work in finalizing this 😊
|
Merging now and if the instrumentation tests are an issue we can get to them in #652 :) |
Description
This PR addresses issue #650 by implementing the following improvements to the download data UI on the keyboard:
InterfaceVariables.ktfor all 8 supported languages. This maps it locally within the keyboard without usingScribe-i18n.ic_arrow_circle_down_24Material icon to match the UI mockups.FrameLayout.Related Issue
Fixes #650
Changes Made
app/src/main/res/layout/input_method_view.xml: Wrapped the empty state banner in aFrameLayoutand reduced icon padding.app/src/keyboards/java/be/scri/services/GeneralKeyboardIME.kt: Upgraded the banner color assignments to render proper Dark mode aesthetics, added click event intent extra ("navigate_to").app/src/keyboards/java/be/scri/activities/MainActivity.kt: Set up aLaunchedEffectlistener that detects the intent extra and navigates to the"download_data"route.app/src/main/res/drawable/ic_arrow_circle_down_24.xml: Created the missing UI icon.app/src/keyboards/java/be/scri/helpers/KeyboardLanguageMappingConstants.kt&.../*InterfaceVariables.kt: HardcodedDOWNLOAD_DATA_LBL.Screenshots