Skip to content

Fix UI and navigation for download data banner #653

Merged
andrewtavis merged 7 commits into
scribe-org:mainfrom
prince-0408:fix-download-data-ui-650
Jul 12, 2026
Merged

Fix UI and navigation for download data banner #653
andrewtavis merged 7 commits into
scribe-org:mainfrom
prince-0408:fix-download-data-ui-650

Conversation

@prince-0408

Copy link
Copy Markdown
Contributor

Description

This PR addresses issue #650 by implementing the following improvements to the download data UI on the keyboard:

  • Navigation Update: Re-routed the "Please download language data" banner so that it directs the user to the Data Download page instead of the Installation page.
  • Hardcoded Strings: Added the unlocalized "Please download language data" string directly into the InterfaceVariables.kt for all 8 supported languages. This maps it locally within the keyboard without using Scribe-i18n.
  • UI Enhancements:
    • Designed and imported a new ic_arrow_circle_down_24 Material icon to match the UI mockups.
    • Packaged the text and icon tightly together and centered them perfectly by wrapping the button contents in a FrameLayout.
    • Adjusted the layout padding/height to match design spacing.
    • Refined the banner background and outline for consistency with the design mockups across both Light and Dark modes. The Dark mode now correctly features a dark background with a 1.5dp orange outline and orange text/icon.

Related Issue

Fixes #650

Changes Made

  • app/src/main/res/layout/input_method_view.xml: Wrapped the empty state banner in a FrameLayout and reduced icon padding.
  • app/src/keyboards/java/be/scri/services/GeneralKeyboardIME.kt: Upgraded the banner color assignments to render proper Dark mode aesthetics, added click event intent extra ("navigate_to").
  • app/src/keyboards/java/be/scri/activities/MainActivity.kt: Set up a LaunchedEffect listener that detects the intent extra and navigates to the "download_data" route.
  • app/src/main/res/drawable/ic_arrow_circle_down_24.xml: Created the missing UI icon.
  • app/src/keyboards/java/be/scri/helpers/KeyboardLanguageMappingConstants.kt & .../*InterfaceVariables.kt: Hardcoded DOWNLOAD_DATA_LBL.

Screenshots

Light Mode Dark Mode
Light mode dark mode

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's looking and working great here, @prince-0408! Thanks so much for the great work in finalizing this 😊

@andrewtavis andrewtavis added the -next release- Included in the next release label Jul 12, 2026
@andrewtavis

Copy link
Copy Markdown
Member

Merging now and if the instrumentation tests are an issue we can get to them in #652 :)

@andrewtavis
andrewtavis merged commit 5c3ba1c into scribe-org:main Jul 12, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-next release- Included in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements to download data UI

2 participants