Monitoring data support ("Data Tables")#967
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…ts stored procedure, not via triggers
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| state = 'running', | ||
| progress_message = 'uploaded', | ||
| started_at = now(), | ||
| timeout_at = timezone('utc', now()) + interval '60 seconds' |
There was a problem hiding this comment.
Sixty second upload timeout
High Severity
The timeout_at for data_table_upload jobs is set to 60 seconds in submit_overlay_data_table_upload. This is often too short for the actual processing, leading to background cleanup marking jobs as failed. Consequently, complete_overlay_data_table_upload cannot finalize these jobs, causing successful uploads to appear as failures without creating a new data table.
Reviewed by Cursor Bugbot for commit 0284327. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1015a18. Configure here.
|
|
||
| update project_background_jobs | ||
| set state = 'complete', progress = 1, progress_message = 'complete', error_message = null | ||
| where id = job_id; |
There was a problem hiding this comment.
Complete overwrites failed job
Medium Severity
The complete_overlay_data_table_upload function's final project_background_jobs update lacks a state check. This allows a race condition where a concurrently failed or timed-out job can be incorrectly marked complete, leading to an inconsistent state where a new data table exists but the job status is misleading.
Reviewed by Cursor Bugbot for commit 1015a18. Configure here.
| before insert on table_of_contents_items | ||
| for each row execute function trg_copy_data_table_settings_from_draft_toc(); | ||
|
|
||
| drop index if exists overlay_data_tables_active_name_per_toc; |
There was a problem hiding this comment.
Duplicate active table names
Low Severity
Migration 000430 drops the partial unique index overlay_data_tables_active_name_per_toc, which previously prevented two non-deleted data tables on the same draft layer from sharing a name. After this change, duplicate active names on one TOC item are allowed, which can break admin UI assumptions and make changelogs or pickers ambiguous.
Reviewed by Cursor Bugbot for commit 1015a18. Configure here.
…cription to clarify dependency management and CI issues.
1 participant
No description provided.