Add wave front invariant static check#32
Merged
Conversation
ninioArtillero
force-pushed
the
wavefront-check
branch
from
July 9, 2026 23:44
fe1fc4c to
9831a19
Compare
ninioArtillero
marked this pull request as ready for review
July 14, 2026 17:47
ninioArtillero
force-pushed
the
wavefront-check
branch
from
July 14, 2026 23:40
9831a19 to
68040c4
Compare
ninioArtillero
force-pushed
the
wavefront-check
branch
from
July 16, 2026 17:00
68040c4 to
7f6ad23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds static checks for the documented invariants of
furtherReachinganddstepwithout introducing semantic effects. For the latter, a LiquidHaskell refinement type aliasWaveFrontis defined, to express the invariant more concisely, and a new phantom (i.e. unused in the source) parameter that passes the current iteration number (or equivalently, the edit trace length of the input node list) is added.Two helper functions
_kdiagand_wfDiagsare defined to be used inside refinement predicates;their names start with an underscore to avoid compiler warnings of unused functions.The
{-@ LIQUID "--ple" @-}pragma is required for the appropriate unfolding of reflected functions (like_wfDiagshere), necessary for the checks to work as expected.cabal benchshows no (noticeable) performance variation.