Skip to content

AmRtpStream::recvDtmfPacket: reject telephone-event packets with unexpected size #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hecko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AmRtpStream::recvDtmfPacket: reject telephone-event packets with unexpected size #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/AmRtpStream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,11 @@ bool AmRtpStream::getRemoteHold() {

void AmRtpStream::recvDtmfPacket(AmRtpPacket* p) {
if (p->payload == getLocalTelephoneEventPT()) {
// a telephone-event payload is exactly sizeof(dtmf_payload_t) bytes; a
// truncated packet would make the cast below read past the received data
// and yield bogus event/volume/duration values.
Comment on lines +858 to +860
if (p->getDataSize() != sizeof(dtmf_payload_t))
return;
dtmf_payload_t* dpl = (dtmf_payload_t*)p->getData();

DBG("DTMF: event=%i; e=%i; r=%i; volume=%i; duration=%i; ts=%u session = [%p]\n",
Expand Down
Loading