move packages out of root#148
Merged
Merged
Conversation
308e8d9 to
a5979a8
Compare
shanedg
commented
Jun 30, 2026
40074d8 to
363aaee
Compare
363aaee to
94b0503
Compare
Nest all packages under "/projects" directory to declutter repo root.
Avoids duplication of eslint ecma version.
Avoid duplication of supported node version across package.json engines.
Make plop a regular dependency instead of a peer.
94b0503 to
95b9613
Compare
shanedg
commented
Jul 8, 2026
| "markdownlint-config", | ||
| "scaffold", | ||
| "typescript" | ||
| "projects/*" |
Owner
Author
There was a problem hiding this comment.
nesting projects under new directory makes it more convenient to define working directories via glob
shanedg
commented
Jul 8, 2026
| path: join(relativePathToRepoRoot, '.vscode', 'settings.json'), | ||
| pattern: /"eslint.workingDirectories": \[/, | ||
| template: ' "{{path}}",', | ||
| }, |
Owner
Author
There was a problem hiding this comment.
no longer necessary with working directories glob!
shanedg
commented
Jul 8, 2026
|
|
||
| const { configs: nodeConfigs } = node; | ||
|
|
||
| const supportedNodeVersionRange = '>=24.16.0'; |
Owner
Author
There was a problem hiding this comment.
single place to adjust node version (for linting purposes) instead of every package.json#engines field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.