perf: read the _merges slot directly instead of getattr#41
Merged
Conversation
_merges is a dataclass field (default None), so it is always initialized; getattr(self, "_merges", None) can just be self._merges. Both call sites (get_merges, merge) are on the hot path — merge runs per subgraph per training step — so dropping the getattr lookup helps. ~2-3% faster across BPE/BNE/Boundless; memory unchanged. Output identical; tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_mergesis a dataclass field with a default ofNone, so it's always initialized —getattr(self, "_merges", None)is equivalent toself._merges. Both call sites (get_merges,merge) are hot (mergeruns per subgraph per training step), so dropping thegetattrlookup helps.Output identical, tests pass. Measured back-to-back (50 texts / 200 merges; best of 3):
Memory unchanged.
🤖 Generated with Claude Code