Skip to content

push_to_review_firm.yml: strip refreshToken to stop silent CONFIG_JSON poisoning #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michieldegezelle wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

push_to_review_firm.yml: strip refreshToken to stop silent CONFIG_JSON poisoning #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d021b3a
TEST: strip refreshToken in push_to_review_firm.yml (CI_AUTH_SAMPLER_…
michieldegezelle Jul 15, 2026
53489f2
Drop stale internal doc reference
michieldegezelle Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/push_to_review_firm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,12 @@ jobs:
run: |
mkdir -p "$HOME/.silverfin"
echo '${{ secrets.CONFIG_JSON }}' > "$HOME/.silverfin/config.json"
# Blank every firm's refreshToken so an expired access token fails cleanly on a 401
# instead of silently rotating (and poisoning) the shared CONFIG_JSON secret this
# workflow never writes back to.
jq 'to_entries | map(if (.key|test("^[0-9]+$")) then .value.refreshToken = "" else . end) | from_entries' \
"$HOME/.silverfin/config.json" > "$HOME/.silverfin/config.stripped.json"
mv "$HOME/.silverfin/config.stripped.json" "$HOME/.silverfin/config.json"
node ./node_modules/silverfin-cli/bin/cli.js config --set-firm="${FIRM_ID}"
node ./node_modules/silverfin-cli/bin/cli.js config --get-firm

Expand Down