Add capture command (snapshot live company-file data as JSON)#259
Closed
Benjvandam wants to merge 1 commit into
Closed
Add capture command (snapshot live company-file data as JSON)#259Benjvandam wants to merge 1 commit into
Benjvandam wants to merge 1 commit into
Conversation
New capture -u <url> [--full] [-o <file>] snapshots a live company file as JSON. Default (scoped) reuses the create-test gathering (buildLiquidTest, extracted from testGenerator); --full fans out company/period/reconciliation customs + results across all periods (serialized per company). Adds lib/dataCapture.js, refactors liquidTestGenerator to expose buildLiquidTest, + tests.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
Consolidated into #260 (one PR for all four live-bridge commands). Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 2 of the live-bridge initiative. Stacked on #258 (base
add-get-results-command); will retarget tomainonce #258 merges.What
New
capture -u <url> [--full] [-o <file>]snapshots a live company file as JSON.--full: fans out company + every period + every workflow reconciliation (customs + results), serialized per company (the API allows 1 in-flight call per company).How
lib/dataCapture.js(capture/captureScoped/captureFull).lib/liquidTestGenerator.jsto exposebuildLiquidTest()(returns the object);testGenerator()now calls it thenexportYAML— create-test behaviour unchanged.bin/cli.js; JSON to stdout or--output.Tests
tests/lib/dataCapture.test.js(scoped + full); existingliquidTestGeneratortest still green after the refactor. Full suite green (565 tests); eslint clean.Note
Account-level customs are captured in scoped mode but not in
--full(no list-accounts endpoint wired in the CLI). Read-only command (no writes).