Add approx integer parsing error-path test coverage#466
Open
mag123c wants to merge 1 commit into
Open
Conversation
Mirrors the correct-parser coverage for the approx-number-parsing feature: leading zeroes, base prefixes (0x/0b/0o), a bare/invalid sign, integers with an exponent marker but no exponent digits, and non-terminator trailing bytes. These InvalidNumber paths in the approx parse_number were previously untested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #465 — the maintainer offered to merge the same coverage for the approx parser.
What
InvalidNumbererror-path tests for theapprox-number-parsinginteger parser, mirroring the correct-parser coverage from Add integer parsing error-path test coverage #465.0x/0b/0o), a bare/invalid sign, an exponent marker with no digits, and non-terminator trailing bytes.to_value_from_strtest helper matching the one incorrect.rs.Notes
approx.rs'sparse_numberalready rejected these inputs, the paths were simply untested.cargo test --features approx-number-parsingandcargo fmt --check.