Skip to content

feat: add support for 'features.agent_view' app manifest property#596

Merged
mwbrooks merged 3 commits into
mainfrom
mwbrooks-manifest-agent-view
Jun 19, 2026
Merged

feat: add support for 'features.agent_view' app manifest property#596
mwbrooks merged 3 commits into
mainfrom
mwbrooks-manifest-agent-view

Conversation

@mwbrooks

@mwbrooks mwbrooks commented Jun 19, 2026

Copy link
Copy Markdown
Member

Changelog

Add support for the new app manifest property features.agent_view. This prevents the CLI from silently dropping agent_view when reading and writing a manifest.

Summary

Supports the upcoming features.agent_view in the Slack app manifest. Without these struct changes the CLI silently drops agent_view when reading and writing a manifest.

  • Mirrors the existing AssistantView shape and reuses the existing SuggestedPrompts type because agent_view and assistant_view are sibling properties.
  • The CLI delegates manifest validation to the backend, so no validator changes are needed - these struct edits ensure the field round-trips cleanly through JSON and YAML.

Related: slackapi/manifest-schema#74

Preview

  • N/A

Testing

# Create a new app
$ ./bin/slack create my-app -t slack-samples/bolt-js-starter-agent --subdir claude-agent-sdk
$ cd my-app/

$ vim manifest.json
# Add the following under "assistant_view":
$ cat manifest.json
    "assistant_view": {
      "assistant_description": "Hi, I am an agent built using Bolt for JavaScript. I am here to help you out!",
      "suggested_prompts": []
    },
    "agent_view": {
      "agent_description": "Hi, I am an agent built using Bolt for JavaScript. I am here to help you out!",
      "suggested_prompts": [],
      "actions": [{
        "name": "open_settings",
        "description": "Open the agent settings panel."
      }]
    },

# Test that the `agent_view` survives reading:
$ ../bin/slack manifest info --source local
# → Confirm "agent_view": { ...

# Clean up
$ cd ../
$ rm -rf my-app/

Requirements

Adds AgentView and AgentViewAction structs and an AgentView field on
AppFeatures so manifests using the new agent_view property survive
JSON/YAML round-trips through the CLI. Mirrors AssistantView and reuses
the existing SuggestedPrompts type.
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.66%. Comparing base (2851328) to head (b171ca1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   71.65%   71.66%           
=======================================
  Files         226      226           
  Lines       19176    19176           
=======================================
+ Hits        13741    13742    +1     
+ Misses       4223     4221    -2     
- Partials     1212     1213    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks self-assigned this Jun 19, 2026
@mwbrooks mwbrooks added enhancement M-T: A feature request for new functionality semver:minor Use on pull requests to describe the release version increment labels Jun 19, 2026
@mwbrooks mwbrooks added this to the Next Release milestone Jun 19, 2026
@mwbrooks mwbrooks changed the title feat: add agent_view manifest types feat: add support for 'features.agent_view' app manifest property Jun 19, 2026
The agent_view JSON marshal cases live in Test_AppManifest_AppFeatures
alongside other features. The standalone round-trip test had no
precedent for sibling properties like assistant_view.
@mwbrooks mwbrooks marked this pull request as ready for review June 19, 2026 05:01
@mwbrooks mwbrooks requested a review from a team as a code owner June 19, 2026 05:01
@zimeg zimeg added the changelog Use on updates to be included in the release notes label Jun 19, 2026

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks LGTM! Approving now with hopes to follow up as feedback arrives more-

},
},
BotUser: BotUser{
DisplayName: "agent_smith",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊 praise: Decisions suggested above! Nice!

@mwbrooks

Copy link
Copy Markdown
Member Author

Thanks for the reviews @zimeg and for adding the 🏷️ changelog label. 🙇🏻

@mwbrooks mwbrooks merged commit f0d20ad into main Jun 19, 2026
9 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-manifest-agent-view branch June 19, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Use on updates to be included in the release notes enhancement M-T: A feature request for new functionality semver:minor Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants