[DX-4553] Add docker build cache dance#1608
Open
kalverra wants to merge 10 commits into
Open
Conversation
erikburt
reviewed
Jul 24, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kalverra
enabled auto-merge (squash)
July 24, 2026 17:11
erikburt
reviewed
Jul 24, 2026
erikburt
left a comment
erikburt
left a comment
Contributor
There was a problem hiding this comment.
Would like to see the /chainlink pr tested against the new changes too.
Comment on lines
+139
to
+148
| cache-dance: | ||
| description: | | ||
| Deprecated: Explicitly enable/disable buildkit-cache-dance. If unset, cache-dance is automatically enabled when cache-map is provided. | ||
| required: false | ||
| default: "" | ||
| cache-dance-cache-map: | ||
| description: | | ||
| Deprecated alias for cache-map. | ||
| required: false | ||
| default: "" |
Contributor
There was a problem hiding this comment.
These are "deprecated" but they were never released in the first place.
erikburt
reviewed
Jul 24, 2026
| module="github.com/smartcontractkit/${dep}" | ||
| else | ||
| module="${dep}" | ||
| fi |
Contributor
There was a problem hiding this comment.
Is there a use-case for supporting arbitrary overrides, if not I think limiting it to smartcontractkit deps makes the most sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
--mount=type=cacheUse the buildkit-cache-dance action to properly enable caching docker layers with
--mount=type=cachein CI. See Docker docs on caching for more info.Consolidate Caching Inputs
1. Unified
cache-modeEnum Presetdocker-restore-cacheanddocker-save-cacheinto a singlecache-modeinput parameter with standard presets:auto(Default): Save onpush/schedule, restore onpull_requestand other events.read-write(ortrue): Force save and restore.read-only: Restore cache only.write-only: Save cache only.off(orfalse): Disable GHA layer caching.2. Auto-Inferred
buildkit-cache-danceviacache-mapcache-dance: "true"explicitly. Providing a non-emptycache-mapautomatically enablesbuildkit-cache-dance.cache-mapadded as the standard input name, withcache-dance-cache-mapretained as a backward-compatible fallback alias.