feat(cct-sdk): Add deploy evm token pool + version resolution#307
feat(cct-sdk): Add deploy evm token pool + version resolution#307apedrob wants to merge 20 commits into
Conversation
…10418-handle-pool-versioning
…10418-handle-pool-versioning
…10418-handle-pool-versioning
…10418-handle-pool-versioning
* feat(cct-sdk): Source token + pool abi/bytecode from contracts-ccip * Remove outdated bytecodes
* feat(cct-sdk): Source token + pool abi/bytecode from contracts-ccip * feat(cct-sdk): Add versioned Deploy Token (CCT + ERC20) * Remove outdated bytecodes * Deploy only CrossChainToken * Recover previous type changes
|
You must have Developer access to commit code to Chainlink Labs on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
mervin-link
left a comment
There was a problem hiding this comment.
Nit: Since we are resolving transferOwnership to token pool interface, maybe it's better to rename it specific to token pool. But it's not a blocker.
|
Re-checked at fa96c23. The previous lockBox correctness issue is fixed:
Remaining lockbox gap (still blocking for me): What is missing:
Please resolve with one of these paths:
|
|
The LockRelease deployTokenPool example still omits lockBox. |
What
deployTokenPooltoEVMTokenManager(build + execute): deploys a TokenPool at 2.0.0, type selects the contract (BurnMintTokenPool,BurnFromMintTokenPool,BurnWithFromMintTokenPool,LockReleaseTokenPool)generateUnsignedDeployTokenPoolfor offline/multisig;deployTokenPoolsigns + submits, returns { hash, contractAddress }resolveTokenPool: read onchain typeAndVersion, narrow to a known pool type + versiontransferOwnershipresolves the pool's real type/version to pick the ABI and floor-match the encoder (was a hardcoded interface)Why
Testing
deployTokenPool(golden-vector init-code per type incl. lockBox, param validation, execute paths)transferOwnershipprobe + version-resolution tests; full CCT suite green, typecheck + lint clean