Fix chain client's SendTransaction_WithSecondaryURLs flakey test#505
Conversation
|
👋 dimriou, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
There was a problem hiding this comment.
Pull request overview
This PR reduces flakiness in TestEthClient_SendTransaction_WithSecondaryURLs by ensuring the chain client has fully verified and marked all nodes (primary + send-only nodes) as alive before attempting to broadcast a transaction, preventing a race where send-only nodes might not receive the broadcast.
Changes:
- Added an
Eventuallywait to ensure all nodes reportAlivebefore callingSendTransaction. - Tightened the polling interval used to assert that both send-only endpoints received the broadcast.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Condition was never satisfied on multiple occasions, leading to flakes.