Skip to content

Fix chain client's SendTransaction_WithSecondaryURLs flakey test#505

Merged
dimriou merged 1 commit into
developfrom
oev-1600_Fix_ChainClient_flake
Jul 17, 2026
Merged

Fix chain client's SendTransaction_WithSecondaryURLs flakey test#505
dimriou merged 1 commit into
developfrom
oev-1600_Fix_ChainClient_flake

Conversation

@dimriou

@dimriou dimriou commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Condition was never satisfied on multiple occasions, leading to flakes.

@dimriou
dimriou requested a review from a team as a code owner July 16, 2026 14:56
Copilot AI review requested due to automatic review settings July 16, 2026 14:56
@github-actions

Copy link
Copy Markdown
Contributor

👋 dimriou, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-evm

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces flakiness in TestEthClient_SendTransaction_WithSecondaryURLs by ensuring the chain client has fully verified and marked all nodes (primary + send-only nodes) as alive before attempting to broadcast a transaction, preventing a race where send-only nodes might not receive the broadcast.

Changes:

  • Added an Eventually wait to ensure all nodes report Alive before calling SendTransaction.
  • Tightened the polling interval used to assert that both send-only endpoints received the broadcast.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dimriou
dimriou enabled auto-merge (squash) July 17, 2026 07:42
@dimriou
dimriou merged commit 7a535cc into develop Jul 17, 2026
36 of 38 checks passed
@dimriou
dimriou deleted the oev-1600_Fix_ChainClient_flake branch July 17, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants