Skip to content

feat: added system and bundleId to telemetry to version 0.8#1312

Open
mkopcins wants to merge 3 commits into
release/0.8from
@mkopcins/telemetry_update_08
Open

feat: added system and bundleId to telemetry to version 0.8#1312
mkopcins wants to merge 3 commits into
release/0.8from
@mkopcins/telemetry_update_08

Conversation

@mkopcins

Copy link
Copy Markdown
Collaborator

Description

Added two new fields to model downloads telemetry: system and bundleId.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Run any new model (to trigger a download event) and check if new event with that bundle id is registered on the website https://ai.swmansion.com/telemetry/admin/downloads

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@mkopcins
mkopcins requested a review from msluszniak July 16, 2026 12:44
@msluszniak msluszniak added the feature PRs that implement a new feature label Jul 16, 2026
@msluszniak msluszniak linked an issue Jul 16, 2026 that may be closed by this pull request
Comment thread apps/llm/package.json
"react": "19.1.0",
"react-native": "0.81.5",
"react-native-audio-api": "^0.8.2",
"react-native-audio-api": "^0.12.2",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need changes to demo app in release* branch?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had troubles testing it with demo app without those changes

@msluszniak msluszniak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no PrivacyInfo.xcprivacy in the package. Sending bundle id + derived country off-device is the kind of collection Apple's privacy-manifest rules cover — pre-existing gap, but this PR makes it more relevant. Same for docs: telemetry has no prose page and no opt-out, and bundleId identifies the app shipping RNE.

Comment thread packages/react-native-executorch/src/utils/ResourceFetcherUtils.ts Outdated
Comment thread packages/react-native-executorch/src/utils/ResourceFetcherUtils.ts Outdated
Comment thread packages/react-native-executorch/src/utils/ResourceFetcherUtils.ts Outdated
@msluszniak

Copy link
Copy Markdown
Member

ios/PrivacyInfo.xcprivacy doesn't exist in the package, the commit adds the resource_bundles reference but not the file itself. The PrivacyInfo.xcprivacy file needs to be committed here, with the actual NSPrivacyCollectedDataTypes entries for the data being sent. Also add ios/PrivacyInfo.xcprivacy to the files array in package.json so it's included in the npm tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature PRs that implement a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add system and bundleId to model downloads telemetry

2 participants