Standardize Statistics error recovery on soft-retry pattern#1232
Open
techisigu wants to merge 1 commit into
Open
Standardize Statistics error recovery on soft-retry pattern#1232techisigu wants to merge 1 commit into
techisigu wants to merge 1 commit into
Conversation
ErrorBoundary's statistics fallback previously called window.location.reload() on retry, a full page reload, while Statistics' own internal error UI (for fetch failures) retries via execute() with no reload. Give ErrorBoundary a reset() method and let fallback be a render function that receives it, so render-crash retries also resolve via an in-place reset rather than a hard navigation. Full reload remains the default fallback behavior for boundaries that don't opt into a custom fallback (e.g. the app-level boundary in layout.tsx), reserved for genuinely unrecoverable crashes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@techisigu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1172
closes #1173
closes #1174
closes #1175
ErrorBoundary's statistics fallback previously called window.location.reload() on retry, a full page reload, while Statistics' own internal error UI (for fetch failures) retries via execute() with no reload. Give ErrorBoundary a reset() method and let fallback be a render function that receives it, so render-crash retries also resolve via an in-place reset rather than a hard navigation. Full reload remains the default fallback behavior for boundaries that don't opt into a custom fallback (e.g. the app-level boundary in layout.tsx), reserved for genuinely unrecoverable crashes.
Description
Type of Change
Testing Done
Bundle Size
Checklist
docs/architecture.mdRelated Issues
Closes #