Fix date format string to ignore per-user Windows regional overrides#62
Merged
Conversation
BaseDateTemplate.GetDefaultFormatString built the default DateTime formatString via new CultureInfo(isoCulture).DateTimeFormat.ShortDatePattern. That constructor defaults to useUserOverride: true, so on a machine where the Windows user has customized Control Panel > Region short-date format (even under a plain "en-US" locale), the emitted formatString silently changes with it - e.g. "yyyy-mm-dd" instead of the culture-defined "m/d/yyyy". This made generated templates non-reproducible across machines and was the actual cause of the StandardConfig_OfflineApply_MatchesSnapshot and CalendarStandardConfig_MatchesSnapshot golden-file failures. Pass useUserOverride: false so the format string depends only on the configured culture, not on the building machine's personal preferences.
marcosqlbi
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseDateTemplate.GetDefaultFormatString built the default DateTime formatString via new CultureInfo(isoCulture).DateTimeFormat.ShortDatePattern. That constructor defaults to useUserOverride: true, so on a machine where the Windows user has customized Control Panel > Region short-date format (even under a plain "en-US" locale), the emitted formatString silently changes with it - e.g. "yyyy-mm-dd" instead of the culture-defined "m/d/yyyy". This made generated templates non-reproducible across machines and was the actual cause of the StandardConfig_OfflineApply_MatchesSnapshot and CalendarStandardConfig_MatchesSnapshot golden-file failures. Pass useUserOverride: false so the format string depends only on the configured culture, not on the building machine's personal preferences.