Skip to content

chore(load balancer): remove local interface #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenhoenle merged 1 commit into from
Jun 22, 2026
+1 −11
Merged

chore(load balancer): remove local interface #1443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions internal/cmd/load-balancer/observability-credentials/update/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,6 @@ const (
credentialsRefArg = "CREDENTIALS_REF" //nolint:gosec // linter false positive
)

// enforce implementation of interfaces
var (
_ loadBalancerClient = loadbalancer.APIClient{}.DefaultAPI
)

type loadBalancerClient interface {
UpdateCredentials(ctx context.Context, projectId, region, credentialsRef string) loadbalancer.ApiUpdateCredentialsRequest
GetCredentials(ctx context.Context, projectId string, region string, credentialsRef string) loadbalancer.ApiGetCredentialsRequest
}

type inputModel struct {
*globalflags.GlobalFlagModel
CredentialsRef string
Expand Down Expand Up @@ -138,7 +128,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
}, nil
}

func buildRequest(ctx context.Context, model *inputModel, apiClient loadBalancerClient) (loadbalancer.ApiUpdateCredentialsRequest, error) {
func buildRequest(ctx context.Context, model *inputModel, apiClient loadbalancer.DefaultAPI) (loadbalancer.ApiUpdateCredentialsRequest, error) {
req := apiClient.UpdateCredentials(ctx, model.ProjectId, model.Region, model.CredentialsRef)

currentCredentials, err := apiClient.GetCredentials(ctx, model.ProjectId, model.Region, model.CredentialsRef).Execute()
Expand Down
Loading