Skip to content

Sanic typing fixes #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gazpachoking merged 2 commits into from
Jun 30, 2026
Merged

Sanic typing fixes #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c86c61a
Allow customized Requests in sanic read_signals type hint
gazpachoking Jun 30, 2026
6098d26
Make sanic DatastarResponse send method compatible with superclass
gazpachoking Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/datastar_py/sanic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ def __init__(

async def send(
self,
event: DatastarEvent | None = None,
data: DatastarEvent | None = None,
end_stream: bool | None = None,
) -> None:
if event and self.status == 204:
if data and self.status == 204:
# When the response is created with no content, it's set to a 204 by default
# if we end up streaming to it, change the status code to 200 before sending.
self.status = 200
await super().send(event, end_stream=end_stream)
await super().send(data, end_stream=end_stream)


async def datastar_respond(
Expand Down Expand Up @@ -96,5 +96,5 @@ async def wrapper(*args: P.args, **kwargs: P.kwargs) -> DatastarResponse | None:
return wrapper


async def read_signals(request: Request) -> dict[str, Any] | None:
async def read_signals(request: Request[Any, Any]) -> dict[str, Any] | None:
return _read_signals(request.method, request.headers, request.args, request.body)