apollo_gateway: stop auto-discovering bench helper as a bench target - #14878
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f3af1b7 to
76e5d24
Compare
408bd90 to
f74c70f
Compare
PR SummaryLow Risk Overview Without this, auto-discovery also treated Reviewed by Cursor Bugbot for commit a95b06d. Bugbot is set up for automated code reviews on this repo. Configure here. |
f74c70f to
cbca040
Compare
f3d6259 to
a03ee34
Compare
cbca040 to
c709d18
Compare
benches/utils.rs is a helper module included by benches/main.rs (the explicit [[bench]], gated on the `testing` feature). Cargo's bench auto-discovery also picked utils.rs up as a standalone, feature-less bench target, so `cargo bench`/`cargo clippy --benches` failed to compile it without `--features testing` (it references apollo_gateway::test_utils). Set autobenches = false so only the explicit [[bench]] is a bench target. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
c709d18 to
a95b06d
Compare
a03ee34 to
25fa398
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on avi-starkware).

benches/utils.rs is a helper module included by benches/main.rs (the explicit
[[bench]], gated on the
testingfeature). Cargo's bench auto-discovery alsopicked utils.rs up as a standalone, feature-less bench target, so
cargo bench/cargo clippy --benchesfailed to compile it without--features testing(it references apollo_gateway::test_utils). Setautobenches = false so only the explicit [[bench]] is a bench target.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com