feat: add ml/strided/dkmeans-closest-centroids#12953
Open
nakul-krishnakumar wants to merge 4 commits into
Open
feat: add ml/strided/dkmeans-closest-centroids#12953nakul-krishnakumar wants to merge 4 commits into
ml/strided/dkmeans-closest-centroids#12953nakul-krishnakumar wants to merge 4 commits into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: passed
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
Author
|
/stdlib update-copyright-years |
kgryte
reviewed
Jun 18, 2026
| * @param sco stride length for `counts` | ||
| * @return pointer to the output array | ||
| */ | ||
| int32_t * API_SUFFIX(stdlib_strided_dclosest_centroids)( const CBLAS_LAYOUT order, const CBLAS_INT M, const CBLAS_INT N, const CBLAS_INT k, const enum STDLIB_ML_KMEANS_METRIC metric, const double *X, const CBLAS_INT LDX, const double *C, const CBLAS_INT LDC, int32_t *out, const CBLAS_INT so, int32_t *counts, const CBLAS_INT sco ) { |
Member
There was a problem hiding this comment.
Suggested change
| int32_t * API_SUFFIX(stdlib_strided_dclosest_centroids)( const CBLAS_LAYOUT order, const CBLAS_INT M, const CBLAS_INT N, const CBLAS_INT k, const enum STDLIB_ML_KMEANS_METRIC metric, const double *X, const CBLAS_INT LDX, const double *C, const CBLAS_INT LDC, int32_t *out, const CBLAS_INT so, int32_t *counts, const CBLAS_INT sco ) { | |
| void API_SUFFIX(stdlib_strided_dclosest_centroids)( const CBLAS_LAYOUT order, const CBLAS_INT M, const CBLAS_INT N, const CBLAS_INT k, const enum STDLIB_ML_KMEANS_METRIC metric, const double *X, const CBLAS_INT LDX, const double *C, const CBLAS_INT LDC, CBLAS_INT *out, const CBLAS_INT so, CBLAS_INT *counts, const CBLAS_INT sco ) { |
kgryte
reviewed
Jun 18, 2026
| * @param oco index offset for `counts` | ||
| * @return pointer to the output array | ||
| */ | ||
| int32_t * API_SUFFIX(stdlib_strided_dclosest_centroids_ndarray)( const CBLAS_INT M, const CBLAS_INT N, const CBLAS_INT k, const enum STDLIB_ML_KMEANS_METRIC metric, const double *X, const CBLAS_INT sx1, const CBLAS_INT sx2, const CBLAS_INT ox, const double *C, const CBLAS_INT sc1, const CBLAS_INT sc2, const CBLAS_INT oc, int32_t *out, const CBLAS_INT so, const CBLAS_INT oo, int32_t *counts, const CBLAS_INT sco, const CBLAS_INT oco ) { |
Member
There was a problem hiding this comment.
Suggested change
| int32_t * API_SUFFIX(stdlib_strided_dclosest_centroids_ndarray)( const CBLAS_INT M, const CBLAS_INT N, const CBLAS_INT k, const enum STDLIB_ML_KMEANS_METRIC metric, const double *X, const CBLAS_INT sx1, const CBLAS_INT sx2, const CBLAS_INT ox, const double *C, const CBLAS_INT sc1, const CBLAS_INT sc2, const CBLAS_INT oc, int32_t *out, const CBLAS_INT so, const CBLAS_INT oo, int32_t *counts, const CBLAS_INT sco, const CBLAS_INT oco ) { | |
| void API_SUFFIX(stdlib_strided_dclosest_centroids_ndarray)( const CBLAS_INT M, const CBLAS_INT N, const CBLAS_INT k, const enum STDLIB_ML_KMEANS_METRIC metric, const double *X, const CBLAS_INT sx1, const CBLAS_INT sx2, const CBLAS_INT ox, const double *C, const CBLAS_INT sc1, const CBLAS_INT sc2, const CBLAS_INT oc, CBLAS_INT *out, const CBLAS_INT so, const CBLAS_INT oo, CBLAS_INT *counts, const CBLAS_INT sco, const CBLAS_INT oco ) { |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves a part of #12875 .
Description
This pull request:
ml/strided/dkmeans-closest-centroids.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Researching on how to use data types which can hold functions in C using ChatGPT.
@stdlib-js/reviewers