feat: estimate transaction fees before Soroban submission - #147
Open
samuelisi wants to merge 1 commit into
Open
Conversation
Add StellarTxService.estimateFee/prepareTransaction, which use SorobanRpc.Server's simulateTransaction and getFeeStats APIs to compute a congestion-aware base fee plus the simulated resource fee, instead of relying on a hardcoded fee value. The inclusion-fee percentile used for the base fee is configurable via STELLAR_FEE_PERCENTILE (defaults to p50). Closes stellar-vortex-protocol#31
|
@samuelisi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StellarTxService(src/soroban/stellar-tx.service.ts) withestimateFeeandprepareTransaction, which useSorobanRpc.Server'ssimulateTransaction+getFeeStatsAPIs to compute base fee + resource fee instead of hardcoding a fee value.stellar.feePercentile, envSTELLAR_FEE_PERCENTILE, defaults top50), falling back toBASE_FEEif fee stats are unavailable or degenerate.SorobanServicewith thin wrappers (getFeeStats,simulateTransaction,prepareTransaction) around the previously-privateSorobanRpc.Serverinstance so this logic is testable without hitting the network.StellarTxServiceinSorobanModuleso it's available for the settlement transaction flows landing in later issues.Closes #31
closes #25
closes #35
closes #32
Test plan
npm run lintnpm run typechecknpm test(24 passed, including 6 new specs instellar-tx.service.spec.tscovering base-fee percentile lookup, fallback toBASE_FEEon RPC failure/degenerate stats, fee-estimate arithmetic, simulation-error handling, and prepared-transaction fee application)npm run test:e2e(23 passed)Full command output
🤖 Generated with Claude Code