Add solver deactivation, deadline bounds, address normalization, and quote response DTO - #156
Open
djcdz4 wants to merge 1 commit into
Open
Add solver deactivation, deadline bounds, address normalization, and quote response DTO#156djcdz4 wants to merge 1 commit into
djcdz4 wants to merge 1 commit into
Conversation
… address case normalization, add quote response DTO - Add POST /api/v1/solvers/:address/deactivate and /reactivate endpoints (closes stellar-vortex-protocol#71) - Add custom validator for CreateIntentDto.deadline with bounds check between now+60s and now+24h (closes stellar-vortex-protocol#72) - Normalize address case comparison in cancel endpoint to match getByUser behavior (closes stellar-vortex-protocol#73) - Add typed QuoteResponseDto with @ApiProperty decorators for Swagger documentation (closes stellar-vortex-protocol#74)
|
@djcdz4 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 4 issues:
Test plan
Closes #71
Closes #72
Closes #73
Closes #74