Fix: document errors, add idempotency, fix pagination, and unify error shapes - #157
Open
amandasmyths wants to merge 1 commit into
Open
Fix: document errors, add idempotency, fix pagination, and unify error shapes#157amandasmyths wants to merge 1 commit into
amandasmyths wants to merge 1 commit into
Conversation
feat: add idempotency key support to intent creation fix: return 400 for pagination limits exceeding maximum fix: unify error response shape across all exception types - Add @apiresponse decorators to all IntentsController routes documenting the specific HTTP exceptions they can throw (404, 409, 403, 410, 400) - Support optional idempotencyKey field in CreateIntentDto to deduplicate requests within a 24-hour TTL window - Validate pagination limit parameter and reject requests with limit > 100 with a 400 response instead of silently clamping - Standardize HttpExceptionFilter to ensure all error responses follow the unified { error: string, details?: unknown } shape - Add tests for pagination limit validation and idempotency deduplication closes stellar-vortex-protocol#75 closes stellar-vortex-protocol#76 closes stellar-vortex-protocol#77 closes stellar-vortex-protocol#78
|
@amandasmyths Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 4 interconnected issues around API documentation, idempotency, and error handling:
Test plan
Changes
closes #75
closes #76
closes #77
closes #78