fix: defensively guard minDstAmount BigInt parsing in fill() - #160
Open
Phantomcall wants to merge 1 commit into
Open
fix: defensively guard minDstAmount BigInt parsing in fill()#160Phantomcall wants to merge 1 commit into
Phantomcall wants to merge 1 commit into
Conversation
Add a try/catch around BigInt(intent.minDstAmount) in IntentsController.fill() that throws a clean BadRequestException with a data-integrity error message instead of letting an unhandled SyntaxError propagate as a 500. Adds an e2e test that corrupts an intent's minDstAmount to a malformed value and asserts the fill endpoint returns 400 with a clear error message.
|
@Phantomcall Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a defensive try/catch around BigInt(intent.minDstAmount) in IntentsController.fill() that throws a clean BadRequestException with a data-integrity error message instead of letting an unhandled SyntaxError propagate as a 500.
Changes
Modified File:
src/intents/intents.controller.tsWrapped
BigInt(intent.minDstAmount)in a try/catch that throws aBadRequestExceptionwith a clear data-integrity error message whenminDstAmountis not a valid integer string. This prevents ungraceful 500 errors from reaching clients when malformed data exists in the database (e.g., from direct DB writes or seed data).Modified File:
test/intents.e2e-spec.tsAdded an e2e test that:
minDstAmountto a malformed valueVerification
Closes #66