feat: add competitive multi-solver acceptance window - #156
Open
favvy994 wants to merge 1 commit into
Open
Conversation
…st-accept-wins Closes stellar-vortex-protocol#51 Implements an optional bid-window mode (off by default) so solvers can compete on price before one is assigned exclusive fill rights. When disabled (default): existing first-accept-wins behavior is fully preserved via accept_intent, with no change to the happy-path lifecycle. When enabled (admin toggles set_bid_window_enabled): - submit_intent opens a BID_WINDOW (120 s) collection period (IntentState::Bidding) instead of Open - Solvers call bid_intent(solver, intent_id, quoted_dst_amount) to submit competing quotes; only the highest quote is retained - After the window closes, anyone calls settle_bids permissionlessly: the highest bidder is assigned and the intent transitions to Accepted with a fresh FILL_WINDOW; fill_intent and slash_solver are unchanged New storage: BestBid(intent_id) -> BestBidRecord{solver, quoted_dst_amount} New errors: BidWindowNotOpen(22), BidWindowStillOpen(23), NoBidsSubmitted(24) New constant: BID_WINDOW = 120 s Tests: 8 new tests covering happy path, no-bids, window-still-open, lower-bid-rejected, and backward-compatibility of first-accept-wins mode.
|
@favvy994 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a competitive bid-window mode behind an admin-controlled flag (off by default), so solvers can compete on quoted price before one is assigned exclusive fill rights. The existing first-accept-wins path is fully preserved when the flag is off.
Design
Problem:
accept_intentis first-write-wins — the first solver to submit a valid transaction claims exclusive fill rights. This may not produce the best execution for users, especially for large intents.Solution: Admin enables
set_bid_window_enabled(true). New intents open inBiddingstate forBID_WINDOW(120 s). Solvers callbid_intent(quoted_dst_amount)to compete on price. After the window, anyone callssettle_bidspermissionlessly — the solver who quoted the highestdst_amountwins and the intent transitions toAcceptedwith a fresh fill window.Backward compatibility: All existing intents in
Openstate continue to useaccept_intent(first-accept-wins). The new path only applies to intents submitted whileBidWindowEnabled = true.Changes
IntentState::BiddingvariantBestBidRecordstruct andDataKey::BestBidstorage keyset_bid_window_enabled/is_bid_window_enabledadmin controlsbid_intent— solver submits a quote during the windowsettle_bids— permissionless; picks highest bidder, transitions toAcceptedBID_WINDOW = 120constantBidWindowNotOpen,BidWindowStillOpen,NoBidsSubmittedValidation
cargo test)cargo fmtandcargo clippy -- -D warningscleanCloses #51