feat: make MIN_BOND, FILL_WINDOW, INTENT_EXPIRY, PROTOCOL_FEE_BPS admin-configurable - #157
Open
favvy994 wants to merge 1 commit into
Open
Conversation
… admin-configurable Closes stellar-vortex-protocol#52 Moves the four compile-time constants to a ProtocolConfig struct stored in instance storage, with an admin-only setter (set_config) and a public getter (get_config). Existing behavior is unchanged: initialize seeds Config with the same default values as before. Changes: - Added ProtocolConfig struct {min_bond, fill_window, intent_expiry, protocol_fee_bps} - Added DataKey::Config instance-storage key - Added set_config(min_bond, fill_window, intent_expiry, protocol_fee_bps) admin fn with bounds: fee ≤ 1000 bps, fill_window ≥ 60 s, intent_expiry ≥ 300 s and > fill_window, min_bond ≥ 10_000_000 (1 token unit) - Added get_config() public view fn - Added Error::InvalidConfig (22) - Added load_config() private helper (falls back to defaults for upgrade safety) - All four constants now read from Config at runtime; original constant names exported as pub const for test backward-compatibility Tests: 9 new tests covering defaults, updates, all bound violations, register_solver respecting new min_bond, and fill_intent using updated fee_bps.
|
@favvy994 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the four compile-time constants to a
ProtocolConfigstruct stored in instance storage with an admin-only setter and public getter. Any change no longer requires a contract redeploy. Existing behavior is fully preserved:initializeseeds config with the original default values.Changes
ProtocolConfigstruct:{min_bond, fill_window, intent_expiry, protocol_fee_bps}DataKey::Configinstance-storage keyset_config(min_bond, fill_window, intent_expiry, protocol_fee_bps)— admin-only, validatedget_config()— public view returning current effective parametersError::InvalidConfig(22) for out-of-bounds valuesload_config()helper with fallback defaults (upgrade-safe)Bounds enforced by set_config
protocol_fee_bpsfill_windowintent_expirymin_bondValidation
cargo test)cargo fmtandcargo clippy -- -D warningscleanCloses #52