feat: add get_protocol_params view function - #158
Open
favvy994 wants to merge 1 commit into
Open
Conversation
Closes stellar-vortex-protocol#53 Adds get_protocol_params() — a read-only view that returns all four effective protocol values (MIN_BOND, FILL_WINDOW, INTENT_EXPIRY, PROTOCOL_FEE_BPS) as a named ProtocolParams struct. Integrators can call this instead of reading source constants, and the struct type ensures field names are always visible at the call site. Adds ProtocolParams{min_bond, fill_window, intent_expiry, protocol_fee_bps} contracttype struct and a test asserting the returned values match the current constants.
|
@favvy994 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
get_protocol_params()read-only view that returns all four effective protocol values as a namedProtocolParamsstruct. Integrators no longer need to read source code to know the current constants.Ships independently of any configurability work — simply returns the existing compile-time constants.
Changes
ProtocolParamscontracttype struct:{min_bond, fill_window, intent_expiry, protocol_fee_bps}get_protocol_params()view functionValidation
cargo test), including one new test asserting returned values match constantscargo fmtandcargo clippy -- -D warningscleanCloses #53