fix: audit deadline boundary semantics across all four lifecycle functions - #159
Open
blessedDev-xyz wants to merge 1 commit into
Open
Conversation
…tent/slash_solver/expire_intent - Add boundary tests (now == deadline) for all four lifecycle functions to document and pin the exact behavior at the boundary second - add/fill use >= (deadline is exclusive for the action window) - slash/expire use < (deadline is inclusive — action is valid at the deadline second itself, not strictly after) - Add rustdoc boundary-semantics comments next to each comparison site Closes stellar-vortex-protocol#42
|
@blessedDev-xyz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audits every
intent.deadlinecomparison in the intent lifecycle and pins the boundary behaviour with explicit tests and rustdoc comments.Findings
now == deadline)accept_intentnow >= deadline[created_at, deadline)fill_intentnow >= deadlineslash_solvernow < deadlineexpire_intentnow < deadlineAll comparisons are logically consistent with the state machine design. The asymmetry (
>=vs<) is intentional:accept/fillprotect the actor in the window;slash/expireopen the action at the boundary.Changes
lib.rs: rustdoc boundary-semantics comments added next to each of the four comparison sitestest.rs: 6 new boundary tests (at exactlynow == deadline) added under a dedicated─── Deadline Boundary TestssectionValidation
cargo fmt,cargo clippy -- -D warnings,cargo test— 61 tests pass, 0 fail.Closes #42