Test/comprehensive coverage - #168
Open
Jambox11 wants to merge 4 commits into
Open
Conversation
|
@Jambox11 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive test coverage for critical contract behaviors: two-solver race conditions on intent acceptance, boundary conditions for bond withdrawals, storage TTL extension near archival
thresholds, and complete error variant reachability.
Changes
#70 — Two-solver race on same intent_id
two_solver_race_on_same_intent_idtestIntentNotOpenactive_intentscounter is unaffected#69 — withdraw_bond boundary test
withdraw_bond_leaving_exactly_min_bond_succeedstestwithdraw_bond_below_exact_min_bond_failstest#68 — Storage TTL extension tests
persistent_intent_ttl_extended_near_thresholdtestpersistent_solver_ttl_extended_near_thresholdtestinstance_ttl_extended_near_thresholdtest#67 — Error variant coverage
intent_already_filled_error_when_fill_called_twicetestnot_initialized_error_when_accessing_admin_before_inittestsolver_inactive_error_when_accepting_after_slash_deactivationtestfill_window_expired_error_when_slash_called_too_earlytestNotes
Ctxfixture and test utilitiesCloses #70, Closes #69, Closes #68, Closes #67