Feature/docs and tests batch - #171
Open
favourawaku wants to merge 3 commits into
Open
Conversation
…hes logic regressions (stellar-vortex-protocol#80)
|
@favourawaku Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This batch addresses four GitHub issues: documentation for intent ID derivation (#82), two test improvements for contract behavior (#79, #81),
and CI infrastructure for mutation testing (#80).
Changes
#82 — Document the intent_id derivation scheme
#79 — Add test asserting expire_intent rejects early call
expire_intent_before_deadline_state_unchanged()testError::DeadlineNotReachedwhen called before deadlineOpenafter failed expiry attempt#81 — Add test for get_stats reflecting cumulative totals
get_stats_reflects_cumulative_totals_across_multiple_fills()test#80 — Add mutation-testing CI job
mutantsjob to .github/workflows/ci.ymlcargo-mutantsto detect inadequately-tested codeTest Results
All 57 existing tests pass. New tests verify:
Closes #82, Closes #79, Closes #81, Closes #80