Feature/i18n extract swapcard - #155
Merged
james2177 merged 2 commits intoJul 28, 2026
Merged
Conversation
Move every user-facing string in SwapCard onto a message catalog so the
component can be translated. Adds the minimal catalog layer this depends
on (the i18n infrastructure issue is not merged yet): a typed English
catalog, a {token} interpolator with default-locale/key fallback, and a
useTranslation hook backed by an optional I18nProvider.
Numeric formatting in the card now follows the active app locale instead
of a hardcoded "en-US" and the browser locale. Rendered output is
byte-identical under the default English locale.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Locale-aware number/currency formatting is owned by issue stellar-vortex-protocol#63, which is assigned separately. Revert SwapCard's formatting calls to their original behavior so this PR stays scoped to string externalization (stellar-vortex-protocol#57). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@Olisachukwuma1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Type of change
Component
vortex-contract)vortex-backend)vortex-frontend)Checklist
Screenshots / notes
closes #57