Feat/goal store folds - #167
Merged
Merged
Conversation
…Goal The claim/finish/abandon protocol is policy, not persistence: every GoalRepository implementation must apply exactly the same per-goal transition or the token guarantees silently diverge. The JSON store's embedded logic — snapshot staleness, envelope enforcement on claim, and the stopped-state merge on finish — moves onto Goal as fold_claim / fold_finish / fold_abandon (with ClaimFold naming what the store must persist). GoalStore delegates; behavior is unchanged (84 tests green). Also extend GoalRepository with add_new / replace_current_for_owner / remove_current_for_owner (object-safe String signatures): hosts that manage one current goal per owner need these through the seam, not only on the concrete JSON store. Motivation for both: PAL's transactional orchestration store implements GoalRepository over SQLite and must not duplicate the fold subtleties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.