fix(ui_terminal): truncate by display width, not byte index - #170
Merged
Conversation
Rendering a tool output line whose byte-index cut landed inside a multi-byte character panicked the render task: end byte index 104 is not a char boundary; it is inside 'ü' Every truncation site sliced with `&s[..n]` where n was a column count, which is both panic-prone and wrong (bytes are not terminal columns). Add `text_util` with width-aware `truncate_to_width` / `truncate_with_ellipsis` and route all truncation through it: the generic tool fallback, the error lines, the compact/command renderers, parameter display values, and the sub-agent instructions summary. The compact renderer's key column offset used `key.len()` too — also a width now, so umlauts in a key no longer shift the value. Found via pal, whose pal_tui carries the same code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering a tool output line whose byte-index cut landed inside a multi-byte character panicked the render task:
end byte index 104 is not a char boundary; it is inside 'ü'
Every truncation site sliced with
&s[..n]where n was a column count, which is both panic-prone and wrong (bytes are not terminal columns).Add
text_utilwith width-awaretruncate_to_width/truncate_with_ellipsisand route all truncation through it: the generic tool fallback, the error lines, the compact/command renderers, parameter display values, and the sub-agent instructions summary. The compact renderer's key column offset usedkey.len()too — also a width now, so umlauts in a key no longer shift the value.Found via pal, whose pal_tui carries the same code.